Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-create purged cluster for databricks_mount for Google Storage #1333

Merged
merged 6 commits into from
May 31, 2022

Conversation

marekbrysa
Copy link
Contributor

@marekbrysa marekbrysa commented May 25, 2022

This way if the cluster is deleted, it will be re-created.

This still leaves an issue where if the service account name changes, new cluster won't be created. You'd have to manually delete the mounting cluster so that new cluster is re-created with updated service account.

Hopefully resolves #1331.

@lgtm-com
Copy link

lgtm-com bot commented May 25, 2022

This pull request introduces 1 alert when merging e8503ac into 0647db0 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@marekbrysa marekbrysa changed the title storage/gs: do not set cluster_id if service_account is provided storage/gs: re-create mounting cluster if it cannot be found by cluster_id May 25, 2022
@alexott
Copy link
Contributor

alexott commented May 26, 2022

@marekbrysa please fix test

@nfx
Copy link
Contributor

nfx commented May 30, 2022

@marekbrysa take a look at implementation in #1345

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1333 (638b9f5) into master (15ee5b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files         121      121           
  Lines       10123    10128    +5     
=======================================
+ Hits         9121     9126    +5     
  Misses        638      638           
  Partials      364      364           
Impacted Files Coverage Δ
storage/gs.go 95.45% <100.00%> (+0.58%) ⬆️

@nfx nfx changed the title storage/gs: re-create mounting cluster if it cannot be found by cluster_id Re-create purged cluster for databricks_mount for Google Storage May 31, 2022
@nfx nfx merged commit e1cb79a into databricks:master May 31, 2022
nfx added a commit that referenced this pull request Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)).
* Apply ownership for UC objects during creation ([#1338](#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)).
* Various documentation fixes ([#1350](#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
@nfx nfx mentioned this pull request Jun 7, 2022
nfx added a commit that referenced this pull request Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)).
* Apply ownership for UC objects during creation ([#1338](#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)).
* Various documentation fixes ([#1350](#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* Added `delta_sharing_*` support to `databricks_metastore` ([databricks#1334](databricks#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([databricks#1353](databricks#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([databricks#1361](databricks#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([databricks#1360](databricks#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([databricks#1354](databricks#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([databricks#1349](databricks#1349)).
* Apply ownership for UC objects during creation ([databricks#1338](databricks#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([databricks#1333](databricks#1333)).
* Various documentation fixes ([databricks#1350](databricks#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] GS mount provider cannot handle mounting cluster deletion
3 participants