Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added databricks_git_credentials pat discovery from common environment variables #1353

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jun 3, 2022

If personal_access_token is not provided, it's sourced from the first environment variable of GITHUB_TOKEN, GITLAB_TOKEN, or AZDO_PERSONAL_ACCESS_TOKEN, that has a non-empty value.

Fixes #1352

@nfx nfx requested a review from a team June 3, 2022 16:20
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1353 (bb76d3d) into master (cdcb3e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   90.10%   90.11%           
=======================================
  Files         122      122           
  Lines       10111    10116    +5     
=======================================
+ Hits         9111     9116    +5     
  Misses        637      637           
  Partials      363      363           
Impacted Files Coverage Δ
repos/resource_git_credential.go 100.00% <100.00%> (ø)

…ent variables

If no value is given for `personal_access_token` attribute, it's sourced from the first environment variable of GITHUB_TOKEN, GITLAB_TOKEN, or AZDO_PERSONAL_ACCESS_TOKEN that has a non-empty value.

Fixes #1352
@nfx nfx merged commit 1f39f5e into master Jun 3, 2022
@nfx nfx deleted the issue/1352 branch June 3, 2022 19:59
nfx added a commit that referenced this pull request Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)).
* Apply ownership for UC objects during creation ([#1338](#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)).
* Various documentation fixes ([#1350](#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
@nfx nfx mentioned this pull request Jun 7, 2022
nfx added a commit that referenced this pull request Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)).
* Apply ownership for UC objects during creation ([#1338](#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)).
* Various documentation fixes ([#1350](#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* Added `delta_sharing_*` support to `databricks_metastore` ([databricks#1334](databricks#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([databricks#1353](databricks#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([databricks#1361](databricks#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([databricks#1360](databricks#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([databricks#1354](databricks#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([databricks#1349](databricks#1349)).
* Apply ownership for UC objects during creation ([databricks#1338](databricks#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([databricks#1333](databricks#1333)).
* Various documentation fixes ([databricks#1350](databricks#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] databricks_git_credential provide personal_access_token through env variable
1 participant