Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_run_as
fixture (#82). A new pytest fixture,make_run_as
, has been added to create an account service principal via theacc
fixture and assign it to a workspace with default permissions, which is removed after the test is complete. The fixture creates a service principal with a random display name and assigns it to the workspace. Users can optionally assign the service principal to account groups for specific actions using theaccount_groups
argument. The returned object contains properties for the workspace client, SQL backend, and SQL execution functions, as well as the display name and application ID of the ephemeral service principal. If desired, thews
fixture can be overridden to make all workspace fixtures provided by the plugin run as the ephemeral service principal, allowing for testing with lower privilege ephemeral service principals and improving security and isolation. This feature is not currently supported with Databricks Metadata Service authentication on Azure Databricks.binary
,gcov_args
,gcov_executable
,gcov_ignore
,gcov_include
,report_type
, andskip_validation
, and changes thefile
andplugin
arguments tofiles
andplugins
, respectively.databrickslabs/sandbox
dependency has been updated from versionacceptance/v0.3.1
to0.4.2
. This update includes the addition of install instructions, more go-git libraries, and modifications to the README to explain how to use the library with thedatabricks labs sandbox
command. Dependency updates include golang.org/x/crypto from version 0.16.0 to 0.17.0. TheRun nightly tests
job in the workflow has also been updated to use the new version of thedatabrickslabs/sandbox/acceptance
image. The commit history for this release shows several commits, including the creation of "[TODO] XXX" issues and a full diff comparison. The pull request includes instructions for triggering Dependabot actions through comments. Reviewers are encouraged to thoroughly examine the changelog and commit history for more detailed information on the changes in this release.make_query
fixture (#81). In the latest update, themake_query
fixture in theredash.py
file has undergone changes to enhance code readability and maintainability. Thesql_query
parameter is now required to be passed as a keyword argument, preventing the possibility of it being mistakenly passed as a positional argument. Furthermore, thecreate
function's signature has been revised to include an explicit * before thesql_query
parameter. It is important to note that these changes have not affected the functionality of the method, but have instead altered the parameter passing style for improved clarity. This minor update is intended to elevate the overall quality of the codebase and promote best practices.notebooks
module toworkspace
(#86). In this release, the internalnotebooks
module has been renamed toworkspace
to better reflect its current functionality of managing and interacting with notebooks and other resources in a Databricks workspace. This renaming applies to the import statements inplugin.py
andtest_notebooks.py
, which has been renamed totest_workspace.py
. Additionally, import statements for making cluster policy and instance pool permissions have been added. The functionality of the imported functions, such asmake_directory
,make_workspace_file
,make_notebook
, andmake_repo
, remains unchanged. This change is part of the fix for issue #59 and aims to improve the clarity and consistency of the codebase. Software engineers adopting this project should update any imports or references to thenotebooks
module to use the newworkspace
module instead.Dependency updates: