Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added special handling for notebooks in Installation.upload(...) #36

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Jan 31, 2024

This PR adds special handling for the return URLs of notebooks.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a35079e) 77.43% compared to head (2f79cbb) 77.11%.

❗ Current head 2f79cbb differs from pull request most recent head 30508a4. Consider uploading reports for the commit 30508a4 to get more accurate results

Files Patch % Lines
src/databricks/labs/blueprint/installation.py 46.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   77.43%   77.11%   -0.33%     
==========================================
  Files          13       13              
  Lines        1241     1254      +13     
  Branches      222      225       +3     
==========================================
+ Hits          961      967       +6     
- Misses        192      197       +5     
- Partials       88       90       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit e1fb21c into main Jan 31, 2024
6 checks passed
@nfx nfx deleted the fix/upload-notebook branch January 31, 2024 16:44
nfx added a commit that referenced this pull request Jan 31, 2024
* Added special handling for notebooks in `Installation.upload(...)` ([#36](#36)).
@nfx nfx mentioned this pull request Jan 31, 2024
nfx added a commit that referenced this pull request Jan 31, 2024
* Added special handling for notebooks in `Installation.upload(...)`
([#36](#36)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant