Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned Installation framework with UCX project #32

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Jan 31, 2024

This pull request introduces several changes to the Installation framework in order to align it with the UCX project. The main changes are the addition of new methods to the Installation class, as well as modifications to the tests in test_installer.py.

In the Installation class, several new methods have been added: load_local, username, remove, workspace_link, workspace_markdown_link, and _host. The load_local method loads an object of a specific type from a local file, while username returns the username associated with the installation. The remove method removes the installation folder from the workspace, and workspace_link and workspace_markdown_link return links to files in the workspace. The _host method returns the host URL for the workspace.

In the test_installer.py file, the tests for the InstallState class have been updated to include a new test for the from_installation method, which creates an InstallState object from an existing Installation object. Additionally, the test_state_corrupt test has been added to test the behavior of the InstallState class when the installation is not found.

Overall, this pull request aims to improve the functionality and robustness of the Installation framework by adding new methods and updating the tests.

Relevant PRs:

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (2f8d21a) 77.95% compared to head (e2ecd49) 77.43%.

Files Patch % Lines
src/databricks/labs/blueprint/installation.py 57.64% 34 Missing and 2 partials ⚠️
src/databricks/labs/blueprint/installer.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   77.95%   77.43%   -0.53%     
==========================================
  Files          13       13              
  Lines        1175     1232      +57     
  Branches      217      222       +5     
==========================================
+ Hits          916      954      +38     
- Misses        172      190      +18     
- Partials       87       88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx changed the title Align Installation framework with UCX project Aligned Installation framework with UCX project Jan 31, 2024
@nfx nfx merged commit 7f294e3 into main Jan 31, 2024
6 of 8 checks passed
@nfx nfx deleted the fix/ucx-install branch January 31, 2024 00:24
nfx added a commit that referenced this pull request Jan 31, 2024
* Aligned `Installation` framework with UCX project ([#32](#32)).
@nfx nfx mentioned this pull request Jan 31, 2024
nfx added a commit that referenced this pull request Jan 31, 2024
* Aligned `Installation` framework with UCX project
([#32](#32)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant