Skip to content

Commit

Permalink
Make hatch a prerequisite (#137)
Browse files Browse the repository at this point in the history
`pip install hatch` sometimes fails depending on local environment
drop the line, and make it a prerequisite, as it is for ucx

---------

Co-authored-by: Eric Vergnaud <eric.vergnaud@databricks.com>
  • Loading branch information
ericvergnaud and ericvergnaud authored Aug 2, 2024
1 parent 98e75bc commit ec82326
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ on:
branches:
- main

env:
HATCH_VERSION: 1.9.4

jobs:
ci:
strategy:
Expand All @@ -32,6 +35,9 @@ jobs:
cache-dependency-path: '**/pyproject.toml'
python-version: ${{ matrix.pyVersion }}

- name: Install hatch
run: pip install hatch==$HATCH_VERSION

- name: Run unit tests
run: |
pip install hatch==1.9.4
Expand All @@ -48,6 +54,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v4.1.7

- name: Install hatch
run: pip install hatch==$HATCH_VERSION

- name: Format all files
run: make dev fmt

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def viz_type(self) -> str:
## Local Setup

This section provides a step-by-step guide to set up and start working on the project. These steps will help you set up your project environment and dependencies for efficient development.

To begin, run `make dev` create the default environment and install development dependencies, assuming you've already cloned the github repo.
Please note that hatch is a prerequisite. You can install hatch using `pip install hatch`.
To begin, run `make dev` to create the default environment and install development dependencies, assuming you've already cloned the github repo.

```shell
make dev
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ clean:
rm -fr **/*.pyc

.venv/bin/python:
pip install hatch
hatch env create

dev: .venv/bin/python
Expand Down

0 comments on commit ec82326

Please sign in to comment.