Propagate tf:"suppress_diff" to child attributes
#981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Propagate diff suppression also to nested fields of a configuration block, if it's marked for diff suppression. * Log more precise log messages when this happens. Fix #942
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
==========================================
- Coverage 85.82% 85.79% -0.04%
==========================================
Files 103 103
Lines 9285 9291 +6
==========================================
+ Hits 7969 7971 +2
- Misses 799 802 +3
- Partials 517 518 +1
|
nfx
added a commit
that referenced
this pull request
Dec 16, 2021
* Added `databricks_library` resource to install library on `databricks_cluster` ([#904](#904)). * Added `databricks_clusters` data resource to list all clusters in the workspace, which might be used to install `databricks_library` on all clusters ([#955](#955)). * Fixed refresh of `library` blocks on a stopped `databricks_cluster` ([#952](#952)). * Whenever a library fails to get installed on a running `databricks_cluster`, we now automatically remove this library, so that the clean state of managed libraries is properly maintained. Without this fix users had to manually go to Clusters UI and remove library from a cluster, where it failed to install. Libraries add up to CREATE and UPDATE timeouts of `databricks_cluster` resource. ([#599](#599)). * Added `token` block to `databricks_mws_workspaces` to avoid unnecessary provider aliasing ([#957](#957)). * Fixed disabling `databricks_global_init_script` ([#958](#958)). * Fixed configuration drift issues with `aws_attributes`, `azure_attributes`, `gcp_attributes`, and `email_notifications` configuration blocks in `databricks_cluster`, `databricks_job`, and `databricks_instance_pool` resources ([#981](#981)). * Improved Databricks CLI auth by eagerly resolving `host`, `username`, `password`, and `token` from the specified `profile`. Added explicit logging of auth parameters in debug logs ([#965](#965)). * TLS timeouts, which may occur during Azure MSI auth, are no longer failing API requests and retried within a normal policy ([#966](#966)). * `debug_headers` provider conf is also logging the `Host` header to help troubleshooting auth issues ([#964](#964)). * Added new experimental resources and increased test coverage. Updated dependency versions: * Bump github.com/golang-jwt/jwt/v4 from 4.1.0 to 4.2.0 * Bump google.golang.org/api from 0.60.0 to 0.63.0 * Bump github.com/Azure/go-autorest/autorest from 0.11.22 to 0.11.23 * Bump github.com/Azure/go-autorest/autorest/azure/auth from 0.5.9 to 0.5.10 * Bump gopkg.in/ini.v1 from 1.66.0 to 1.66.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.9.0 to 2.10.0
Merged
nfx
added a commit
that referenced
this pull request
Dec 16, 2021
Change log: * Added `databricks_library` resource to install library on `databricks_cluster` ([#904](#904)). * Added `databricks_clusters` data resource to list all clusters in the workspace, which might be used to install `databricks_library` on all clusters ([#955](#955)). * Fixed refresh of `library` blocks on a stopped `databricks_cluster` ([#952](#952)). * Whenever a library fails to get installed on a running `databricks_cluster`, we now automatically remove this library, so that the clean state of managed libraries is properly maintained. Without this fix users had to manually go to Clusters UI and remove library from a cluster, where it failed to install. Libraries add up to CREATE and UPDATE timeouts of `databricks_cluster` resource. ([#599](#599)). * Added `token` block to `databricks_mws_workspaces` to avoid unnecessary provider aliasing ([#957](#957)). * Fixed disabling `databricks_global_init_script` ([#958](#958)). * Fixed configuration drift issues with `aws_attributes`, `azure_attributes`, `gcp_attributes`, and `email_notifications` configuration blocks in `databricks_cluster`, `databricks_job`, and `databricks_instance_pool` resources ([#981](#981)). * Improved Databricks CLI auth by eagerly resolving `host`, `username`, `password`, and `token` from the specified `profile`. Added explicit logging of auth parameters in debug logs ([#965](#965)). * TLS timeouts, which may occur during Azure MSI auth, are no longer failing API requests and retried within a normal policy ([#966](#966)). * `debug_headers` provider conf is also logging the `Host` header to help troubleshooting auth issues ([#964](#964)). * Added new experimental resources and increased test coverage. Updated dependency versions: * Bump github.com/golang-jwt/jwt/v4 from 4.1.0 to 4.2.0 * Bump google.golang.org/api from 0.60.0 to 0.63.0 * Bump github.com/Azure/go-autorest/autorest from 0.11.22 to 0.11.23 * Bump github.com/Azure/go-autorest/autorest/azure/auth from 0.5.9 to 0.5.10 * Bump gopkg.in/ini.v1 from 1.66.0 to 1.66.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.9.0 to 2.10.0
kthejoker
reviewed
Dec 16, 2021
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
* Propagate diff suppression also to nested fields of a configuration block, if it's marked for diff suppression. * Log more precise log messages when this happens. Fix databricks#942
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Change log: * Added `databricks_library` resource to install library on `databricks_cluster` ([databricks#904](databricks#904)). * Added `databricks_clusters` data resource to list all clusters in the workspace, which might be used to install `databricks_library` on all clusters ([databricks#955](databricks#955)). * Fixed refresh of `library` blocks on a stopped `databricks_cluster` ([databricks#952](databricks#952)). * Whenever a library fails to get installed on a running `databricks_cluster`, we now automatically remove this library, so that the clean state of managed libraries is properly maintained. Without this fix users had to manually go to Clusters UI and remove library from a cluster, where it failed to install. Libraries add up to CREATE and UPDATE timeouts of `databricks_cluster` resource. ([databricks#599](databricks#599)). * Added `token` block to `databricks_mws_workspaces` to avoid unnecessary provider aliasing ([databricks#957](databricks#957)). * Fixed disabling `databricks_global_init_script` ([databricks#958](databricks#958)). * Fixed configuration drift issues with `aws_attributes`, `azure_attributes`, `gcp_attributes`, and `email_notifications` configuration blocks in `databricks_cluster`, `databricks_job`, and `databricks_instance_pool` resources ([databricks#981](databricks#981)). * Improved Databricks CLI auth by eagerly resolving `host`, `username`, `password`, and `token` from the specified `profile`. Added explicit logging of auth parameters in debug logs ([databricks#965](databricks#965)). * TLS timeouts, which may occur during Azure MSI auth, are no longer failing API requests and retried within a normal policy ([databricks#966](databricks#966)). * `debug_headers` provider conf is also logging the `Host` header to help troubleshooting auth issues ([databricks#964](databricks#964)). * Added new experimental resources and increased test coverage. Updated dependency versions: * Bump github.com/golang-jwt/jwt/v4 from 4.1.0 to 4.2.0 * Bump google.golang.org/api from 0.60.0 to 0.63.0 * Bump github.com/Azure/go-autorest/autorest from 0.11.22 to 0.11.23 * Bump github.com/Azure/go-autorest/autorest/azure/auth from 0.5.9 to 0.5.10 * Bump gopkg.in/ini.v1 from 1.66.0 to 1.66.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.9.0 to 2.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #942