Verify workspace reachability through HTTP client #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Oct 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
- Coverage 83.80% 83.65% -0.16%
==========================================
Files 92 92
Lines 8233 8258 +25
==========================================
+ Hits 6900 6908 +8
- Misses 842 859 +17
Partials 491 491
|
* `WorkspacesAPI.WaitForRunning` used to check if workspace is reachable through `net.Dial` on TCP level, though this scenario ignored HTTPS proxies, which are common for enterprise setup. * `mws.Workspace` now gets `workspace_url` computed in accordance to Accounts API endpoint used from a single place in `WorkspacesAPI.Read`, if there's no `workspace_url` returned in the response, which allows fully unit testing the verification flow. * added `DatabricksClient.ClientForHost` to talk to just created workspace with the same authentication parameters. This fixes #874
Also made test surface smaller
nfx
force-pushed
the
workspace-probe-through-proxy
branch
from
bd7df75 to
a6effac
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkspacesAPI.WaitForRunningused to check if workspace is reachable throughnet.Dialon TCP level, though this scenario ignored HTTPS proxies, which are common for enterprise setup.mws.Workspacenow getsworkspace_urlcomputed in accordance to Accounts API endpoint used from a single place inWorkspacesAPI.Read, if there's noworkspace_urlreturned in the response, which allows fully unit testing the verification flow.DatabricksClient.ClientForHostto talk to just created workspace with the same authentication parameters.This fixes #874