Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy E2 with 1 NAT Gateway only by default #870

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

shuwu-db
Copy link
Contributor

Adding

  1. single_nat_gateway = true
  2. one extra public subnet to host the single nat gateway inside the VPC module

for E2 workspace creation

@nfx
Copy link
Contributor

nfx commented Oct 23, 2021

Thank you 🙏🏻

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #870 (31dedba) into master (8947e92) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   83.78%   83.80%   +0.01%     
==========================================
  Files          92       92              
  Lines        8229     8229              
==========================================
+ Hits         6895     6896       +1     
+ Misses        843      842       -1     
  Partials      491      491              
Impacted Files Coverage Δ
sqlanalytics/resource_widget.go 86.13% <0.00%> (+0.72%) ⬆️

@nfx nfx merged commit 9a19db8 into databricks:master Oct 23, 2021
@shuwu-db shuwu-db deleted the nat-gateway-fix branch October 24, 2021 12:19
@nfx nfx mentioned this pull request Oct 29, 2021
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants