Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for databricks_pipeline & make test-preview runnable #673

Merged
merged 6 commits into from
Jun 1, 2021

Conversation

nfx
Copy link
Contributor

@nfx nfx commented May 28, 2021

This pr fixes #606

@nfx
Copy link
Contributor Author

nfx commented May 28, 2021

preview

  • TestPreviewAccDashboard (862.77s)
  • TestPreviewAccQuery (185.40s)
  • TestPreviewAccSQLEndpoint (335.28s)
  • TestPreviewAccSQLEndpoints (1200.62s)
  • compute/acceptance.TestPreviewAccPipelineResource_CreatePipeline (11.14s)

@nfx nfx requested a review from alexott May 31, 2021 17:02
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, not clear why we get a panic in the Update function

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #673 (9f58e48) into master (b3d5ec8) will decrease coverage by 0.01%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.02%     
==========================================
  Files          86       86              
  Lines        7912     7921       +9     
==========================================
+ Hits         6574     6580       +6     
- Misses        864      866       +2     
- Partials      474      475       +1     
Impacted Files Coverage Δ
common/resource.go 64.70% <0.00%> (-8.63%) ⬇️
compute/resource_pipeline.go 89.01% <33.33%> (-4.10%) ⬇️
compute/resource_cluster.go 78.02% <100.00%> (ø)
compute/resource_instance_pool.go 95.69% <100.00%> (+5.79%) ⬆️
compute/resource_job.go 85.92% <100.00%> (ø)
sqlanalytics/resource_sql_endpoint.go 87.50% <100.00%> (+0.83%) ⬆️
sqlanalytics/resource_widget.go 83.45% <0.00%> (+0.75%) ⬆️

@nfx
Copy link
Contributor Author

nfx commented Jun 1, 2021

Code looks good, not clear why we get a panic in the Update function

@alexott , Should be fixed now. It was related to failure handling on continuous pipelines.

@nfx nfx merged commit c7ff746 into master Jun 1, 2021
@nfx nfx deleted the fix/606 branch June 1, 2021 09:18
@nfx
Copy link
Contributor Author

nfx commented Jun 1, 2021

preview

  • TestPreviewAccSQLEndpoints (1200.95s)
  • compute/acceptance.TestPreviewAccPipelineResource_CreatePipeline (393.72s)
  • sqlanalytics/acceptance.TestPreviewAccDashboard (302.75s)
  • sqlanalytics/acceptance.TestPreviewAccQuery (307.88s)
  • sqlanalytics/acceptance.TestPreviewAccSQLEndpoint (357.09s)

@nfx nfx mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make test-preview should be passing with every release
2 participants