Ensure consistent slashes in notebook paths for different OSes #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
approved these changes
Feb 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 76 76
Lines 6382 6382
=======================================
Hits 5157 5157
Misses 847 847
Partials 378 378
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
filepath.ToSlashon the input to mkdir to ensure that path separator stays consistent over different OSes. On Windows systems it would be translated to\before sending the request to databricks, which isn't supported.Fixes #496