-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added databricks_workspace_conf resource #398
Conversation
Travis tests have failedHey @nfx, 2nd Buildcurl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0
time make lint
time make test
TravisBuddy Request Identifier: cccf3ee0-1e16-11eb-8505-818d591f0ed7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the updates. Much more flexible map with keyjoin for values and proper for loops for setting :). Dubious commented out acceptance test. Not sure why the delete in the test framework tries to use the IP Access List API to delete a Workspace Conf object.
InstanceState: map[string]string{ "custom_config.enableSomething": "true", }, HCL: `custom_config { enableIpAccessLists = "true" }`,
Hey @nfx, TravisBuddy Request Identifier: b52d0400-1ecc-11eb-b069-4b84fe73ac29 |
databricks_workspace_conf Resource
Manages workspace configuration for expert usage. Currently, more than one instance of resource can exist in Terraform state, though there's no deterministic behavior, when they manage same property. We strongly recommend to use single
databricks_workspace_conf
per workspace.Example Usage
Allows specification of custom configuration properties for expert usage:
enableIpAccessLists
- enables the use ofdatabricks_ip_access_list
resourcesArgument Reference
The following arguments are available:
custom_config
- (Required) Key-value map of strings, that represent workspace configuration. Upon resource deletion, properties that start withenable
orenforce
will be reset tofalse
value, regardless of initial default one.Import
This resource cannot support import.