Added LocalSsdCount in GcpAttributes to ForceSendFields for databricks_cluster resource
#3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
requested review from
mgyucht,
andrewnester and
edwardfeng-db
and removed request for
a team
tanmay-db
changed the title
LocalSsdCount in GcpAttributes to ForceSendFieldsLocalSsdCount in GcpAttributes to ForceSendFields for databricks_cluster resource
|
Does it mean it will send |
andrewnester
requested changes
May 30, 2024
clusters/resource_cluster.go
Outdated
| @@ -383,6 +383,9 @@ func resourceClusterCreate(ctx context.Context, d *schema.ResourceData, c *commo | |||
| if createClusterRequest.Autoscale == nil { | |||
| createClusterRequest.ForceSendFields = []string{"NumWorkers"} | |||
| } | |||
| if createClusterRequest.GcpAttributes != nil { | |||
| createClusterRequest.GcpAttributes.ForceSendFields = []string{"LocalSsdCount"} | |||
There was a problem hiding this comment.
We should call GetOkExists for local_ssd_count to check that it was explicitly set and only then send it. The reason is that if not specified in request, the default value for local_ssd_count on backend is not 0 (can be 1, 2, 4 depending on type of instance used).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
- Coverage 81.65% 81.65% -0.01%
==========================================
Files 193 193
Lines 19536 19539 +3
==========================================
+ Hits 15953 15955 +2
- Misses 2633 2634 +1
Partials 950 950
|
andrewnester
approved these changes
May 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We always force send the local ssd count if gcp attribute is specified.
Tests
Updated unit test
make testrun locallydocs/folderinternal/acceptance