Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Go SDK to 0.19.2 #2684

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Bumped Go SDK to 0.19.2 #2684

merged 5 commits into from
Sep 13, 2023

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Sep 13, 2023

Changes

This contains a fix for cannot reset nil reader

Tests

Integration tests passed for previous commit -- rolling rest of changing shouldn't affect, running integration tests but they shouldn't be a blocker for this.

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@tanmay-db tanmay-db requested review from a team as code owners September 13, 2023 13:27
@tanmay-db tanmay-db requested review from mgyucht and removed request for a team September 13, 2023 13:27
@tanmay-db tanmay-db requested a review from pietern September 13, 2023 13:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #2684 (599cf3d) into master (a26000f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2684   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files         146      146           
  Lines       12668    12668           
=======================================
  Hits        10983    10983           
  Misses       1118     1118           
  Partials      567      567           

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the unrelated version bumps.

@tanmay-db tanmay-db enabled auto-merge September 13, 2023 15:49
@tanmay-db tanmay-db added this pull request to the merge queue Sep 13, 2023
Merged via the queue into databricks:master with commit 7be5400 Sep 13, 2023
@tanmay-db tanmay-db deleted the bumpGo branch September 13, 2023 16:07
@tanmay-db tanmay-db mentioned this pull request Sep 13, 2023
5 tasks
nkvuong pushed a commit that referenced this pull request Oct 3, 2023
* bump Go SDK to 0.19.2

* bump Go SDK to 0.19.2

* all

* -

* tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants