Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metastore.md #2547

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Update metastore.md #2547

merged 1 commit into from
Aug 2, 2023

Conversation

charlottevdscheun
Copy link
Contributor

Changes

The wrong argument was put in the example of data source metastore

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@charlottevdscheun charlottevdscheun requested review from a team as code owners August 2, 2023 10:00
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Maybe we really need to support id as well

@codecov-commenter
Copy link

Codecov Report

Merging #2547 (e42285c) into master (754aad4) will decrease coverage by 0.03%.
Report is 14 commits behind head on master.
The diff coverage is 83.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2547      +/-   ##
==========================================
- Coverage   88.21%   88.18%   -0.03%     
==========================================
  Files         145      145              
  Lines       11989    12046      +57     
==========================================
+ Hits        10576    10623      +47     
- Misses        930      935       +5     
- Partials      483      488       +5     
Files Changed Coverage Δ
catalog/resource_grants.go 96.22% <ø> (ø)
common/version.go 80.00% <ø> (ø)
jobs/resource_job.go 91.57% <ø> (ø)
sql/data_sql_warehouse.go 83.67% <76.00%> (-9.19%) ⬇️
exporter/importables.go 89.09% <87.87%> (-0.04%) ⬇️
access/resource_ip_access_list.go 80.95% <100.00%> (ø)
sql/resource_sql_endpoint.go 97.59% <100.00%> (+0.09%) ⬆️

@charlottevdscheun
Copy link
Contributor Author

thank you! Maybe we really need to support id as well

Should make sense, most of the data sources have the same attributes. id would be a nice generic one, same as name

@nfx nfx added this pull request to the merge queue Aug 2, 2023
Merged via the queue into databricks:master with commit 65b0921 Aug 2, 2023
@mgyucht mgyucht mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants