-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added READ_VOLUME and WRITE_VOLUME to schema/catalog level grants #2529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add this to catalog level grants, as it is also supported via inheritance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2529 +/- ##
=======================================
Coverage 88.20% 88.20%
=======================================
Files 145 145
Lines 11982 11982
=======================================
Hits 10569 10569
Misses 930 930
Partials 483 483
|
Changes
According to the Databricks documentation & the docs in this repo, you should be able to have
READ_VOLUME
andWRITE_VOLUME
at the schema level. However, this currently fails here.Example resource block:
Error:
It seems like this was missed during this PR, even though the docs were updated correctly.
This is my first contribution, so please let me know if I am missing something! Thanks!
Tests
make test
run locallyrelevant change indocs/
foldercovered with integration tests ininternal/acceptance
relevant acceptance tests are passingusing Go SDK