Fixed databricks_entitlements resource edge behaviour
#2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvuong
force-pushed
the
fix/entitlements
branch
from
4f6fd3e to
4d1a14e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2409 +/- ##
=======================================
Coverage 88.47% 88.48%
=======================================
Files 141 141
Lines 11663 11673 +10
=======================================
+ Hits 10319 10329 +10
Misses 893 893
Partials 451 451
|
nkvuong
force-pushed
the
fix/entitlements
branch
from
8ec7fc3 to
facebd9
Compare
|
acceptance tests passed on 3 clouds |
alexott
reviewed
Jun 15, 2023
| @@ -28,7 +28,7 @@ func ResourceEntitlements() *schema.Resource { | |||
| addEntitlementsToSchema(&entitlementSchema) | |||
| return common.Resource{ | |||
| Create: func(ctx context.Context, d *schema.ResourceData, c *common.DatabricksClient) error { | |||
| return patchEntitlements(ctx, d, c, "add") | |||
| return patchEntitlements(ctx, d, c, "replace") | |||
There was a problem hiding this comment.
My concern here is that we initialize entitlements with false, and when we start to replace them instead of adding, then people may lose the access?
There was a problem hiding this comment.
this resource is meant to enforce entitlement of said identity - the update function will enforce the entitlements anyway, so this change is to make it consistent
nfx
approved these changes
Jun 19, 2023
nfx
changed the title
databricks_entitlements resource edge behaviourdatabricks_entitlements resource edge behaviour
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix edge cases behaviour for
databricks_entitlementsfalseError: cannot delete entitlements: invalidPath No such attribute with the name : entitlements in the current resourceClose #2382
Tests
make testrun locallydocs/folderinternal/acceptanceusing Go SDK