Migrated databricks_ip_access_list resource to Go SDK
#2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
reviewed
May 16, 2023
nfx
requested changes
May 17, 2023
tanmay-db
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
- Coverage 88.67% 88.58% -0.10%
==========================================
Files 140 140
Lines 11551 11546 -5
==========================================
- Hits 10243 10228 -15
- Misses 874 879 +5
- Partials 434 439 +5
|
tanmay-db
commented
May 19, 2023
| common.DataToStructPointer(d, s, &iacl) | ||
| return NewIPAccessListsAPI(ctx, c).Update(d.Id(), iacl) | ||
| iacl.IpAccessListId = d.Id() |
There was a problem hiding this comment.
We need to do this because Update call doesn't take id so we have to pass it through the resource data.
Any reason why we don't pass id through the Update method call?
tanmay-db
commented
May 19, 2023
Comment on lines
+25
to
+26
| TestingIpAddresses = []string{"1.2.3.4", "1.2.4.0/24"} | ||
| TestingIpAddressesState = []any{"1.2.3.4", "1.2.4.0/24"} |
There was a problem hiding this comment.
We should rename this (IP -> Ip) as well for consistency (although not required)
tanmay-db
commented
May 19, 2023
| UpdatedAt: 87939234, | ||
| UpdatorUserID: 1234556, | ||
| Enabled: TestingEnabled, | ||
| Method: http.MethodPatch, |
There was a problem hiding this comment.
Put -> Patch because: https://docs.databricks.com/api-explorer/workspace/ipaccesslists/update update uses PATCH. Can this be breaking for customers? Also why was put using query parameters earlier (wasn't taking expected request)? Should put use body?
tanmay-db
commented
May 19, 2023
Comment on lines
-40
to
-43
| Label string `json:"label"` | ||
| ListType string `json:"list_type"` | ||
| IPAddresses []string `json:"ip_addresses"` | ||
| Enabled bool `json:"enabled,omitempty" tf:"default:true"` |
There was a problem hiding this comment.
Since all these are same, I don't think updates is needed in docs.
nfx
requested changes
May 19, 2023
tanmay-db
changed the title
databricks_ip_access_list Resource to Go SDK
nfx
changed the title
databricks_ip_access_list Resource to Go SDKdatabricks_ip_access_list resource to Go SDK
Merged
nfx
added a commit
that referenced
this pull request
May 22, 2023
* **Removed support for releasing 32-bit binaries** ([#2315](#2315), [#2320](#2320)). * Added more information on impact of using a cluster policy in [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/cluster) resource ([#2313](#2313)). * Added missing `serverless` option to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) ([#2308](#2308)). * Updated `channel` and `edition` values in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) docs ([#2322](#2322)). * Automatically add `CAN_MANAGE` permission on [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) for calling user ([#2298](#2298)). * Migrated [databricks_ip_access_list](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/ip_access_list) resource to Go SDK ([#2306](#2306)). Updated dependency versions: * Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 ([#2317](#2317)). * Bump github.com/databricks/databricks-sdk-go from v0.8.1 to v0.9.0 ([#2327](#2327)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallydocs/folderinternal/acceptanceIntegration test: internal/acceptance/ip_access_list_test.go. Full integration test suite is also running successfully.