Exporter: phase 1 of support for Account-level exports #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2205 +/- ##
==========================================
- Coverage 88.78% 88.69% -0.09%
==========================================
Files 137 137
Lines 11262 11282 +20
==========================================
+ Hits 9999 10007 +8
- Misses 852 859 +7
- Partials 411 416 +5
|
Implemented export of users/groups/service principals on account level, including generation of corresponding role objects to support `account_admin` role. To support role export, was need to make roles exclusion for users/service principals configurable. Current limitation: not all users & service principals could be exported - will require addition of the dedicated `List` implementation for these resources, as `account users` group isn't returned by the API.
alexott
force-pushed
the
exporter-account-level-1
branch
from
9613e50 to
348746a
Compare
|
rebase is done |
nfx
approved these changes
Apr 13, 2023
nfx
added a commit
that referenced
this pull request
Apr 14, 2023
# Version changelog ## 1.14.3 * Add exporter support for [databricks_sql_alert](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_alert) ([#2207](#2207)). * Add support for notifications in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#2218](#2218)). * Add suppress diff for `path` argument of [databricks_directory](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/directory) resource when it ends with `/` ([#2204](#2204)). * Exporter: don't export `storage` when [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) was created with default value ([#2203](#2203)). * Exporter: phase 1 of support for Account-level exports ([#2205](#2205)). * Fixed regression in [databricks_group](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/group) data not to require workspace admin privileges ([#2210](#2210)). * Suppress diff for `edition` attribute in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) ([#2219](#2219)).
Merged
nfx
added a commit
that referenced
this pull request
Apr 14, 2023
# Version changelog ## 1.14.3 * Add exporter support for [databricks_sql_alert](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_alert) ([#2207](#2207)). * Add support for notifications in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#2218](#2218)). * Add suppress diff for `path` argument of [databricks_directory](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/directory) resource when it ends with `/` ([#2204](#2204)). * Exporter: don't export `storage` when [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) was created with default value ([#2203](#2203)). * Exporter: phase 1 of support for Account-level exports ([#2205](#2205)). * Fixed regression in [databricks_group](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/group) data not to require workspace admin privileges ([#2210](#2210)). * Suppress diff for `edition` attribute in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) ([#2219](#2219)).
slwbuild
pushed a commit
to slwbuild/terraform-provider-databricks
that referenced
this pull request
Apr 24, 2023
Implemented export of users/groups/service principals on account level, including generation of corresponding role objects to support `account_admin` role. To support role export, was need to make roles exclusion for users/service principals configurable. Current limitation: not all users & service principals could be exported - will require addition of the dedicated `List` implementation for these resources, as `account users` group isn't returned by the API.
slwbuild
pushed a commit
to slwbuild/terraform-provider-databricks
that referenced
this pull request
Apr 24, 2023
# Version changelog ## 1.14.3 * Add exporter support for [databricks_sql_alert](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_alert) ([databricks#2207](databricks#2207)). * Add support for notifications in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([databricks#2218](databricks#2218)). * Add suppress diff for `path` argument of [databricks_directory](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/directory) resource when it ends with `/` ([databricks#2204](databricks#2204)). * Exporter: don't export `storage` when [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) was created with default value ([databricks#2203](databricks#2203)). * Exporter: phase 1 of support for Account-level exports ([databricks#2205](databricks#2205)). * Fixed regression in [databricks_group](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/group) data not to require workspace admin privileges ([databricks#2210](databricks#2210)). * Suppress diff for `edition` attribute in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) ([databricks#2219](databricks#2219)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implemented export of users/groups/service principals on account level, including generation of corresponding role objects to support
account_adminrole.To support role export, was need to make roles exclusion for users/service principals configurable.
Current limitation: not all users & service principals could be exported - will require addition of the dedicated
Listimplementation for these resources, asaccount usersgroup isn't returned by the API. They will be implemented in the phase 2, together with additional test coverageTests
make testrun locallydocs/folderinternal/acceptance