[PLAT-73750] Add TF for privateaccesssettings on GCP. #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Mar 8, 2023
| @@ -16,3 +16,17 @@ func TestMwsAccPrivateAccessSettings(t *testing.T) { | |||
| }`, | |||
| }) | |||
| } | |||
|
|
|||
| func TestMwsGcpAccPrivateAccessSettings(t *testing.T) { | |||
| t.SkipNow() | |||
There was a problem hiding this comment.
Thanks for reminding! I just ran it.
grayluck
approved these changes
Mar 9, 2023
jessiedu-db
force-pushed
the
jessiedu-PLAT-73750-1
branch
from
3a1d089 to
bbe208d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
==========================================
- Coverage 89.78% 89.60% -0.19%
==========================================
Files 136 136
Lines 11077 11055 -22
==========================================
- Hits 9946 9906 -40
- Misses 732 743 +11
- Partials 399 406 +7
|
nfx
approved these changes
Mar 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAT-73750 Add TF for privateaccesssettings on GCP.
Ran integration test:
scripts/run.sh gcp-accounts 'TestMwsGcpAccPrivateAccessSettings' --debug --tee
Test passed.