Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic diff for databricks_permissions #2059

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Deterministic diff for databricks_permissions #2059

merged 1 commit into from
Mar 2, 2023

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Mar 2, 2023

This PR removes SDK client as the argument to CustomizeDiff callback on the level of common.Resource framework. All customize diff validation must be hermetic and take only schema.ResourceDiff as the input. Any validation, that may require calls to the platform must be done in scope of Create or Update callbacks.

Fix #2052

This PR removes SDK client as the argument to CustomizeDiff callback on the level of `common.Resource` framework. All customize diff validation must be hermetic and take only `schema.ResourceDiff` as the input. Any validation, that may require calls to the platform must be done in scope of Create or Update callbacks.

Fix #2052
@codecov-commenter
Copy link

Codecov Report

Merging #2059 (2098048) into master (5d55691) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
+ Coverage   89.74%   89.79%   +0.04%     
==========================================
  Files         136      136              
  Lines       11074    11079       +5     
==========================================
+ Hits         9938     9948      +10     
+ Misses        735      732       -3     
+ Partials      401      399       -2     
Impacted Files Coverage Δ
permissions/resource_permissions.go 91.73% <66.66%> (+1.90%) ⬆️
catalog/resource_grants.go 96.22% <100.00%> (ø)
catalog/resource_table.go 100.00% <100.00%> (ø)
common/resource.go 77.70% <100.00%> (+1.79%) ⬆️
jobs/resource_job.go 95.78% <100.00%> (ø)
mws/resource_mws_workspaces.go 87.78% <100.00%> (ø)

@nfx nfx merged commit 9aa654b into master Mar 2, 2023
@nfx nfx deleted the issue/2052 branch March 2, 2023 10:31
@nfx nfx mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_permissions resource since 1.10.0
2 participants