Don't consider GPU-based nodes in databricks_node_type data source until explicitly requested
#1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1978 +/- ##
==========================================
- Coverage 90.36% 90.34% -0.02%
==========================================
Files 146 146
Lines 11901 11901
==========================================
- Hits 10754 10752 -2
- Misses 741 742 +1
- Partials 406 407 +1
|
…until explicitly requested
alexott
force-pushed
the
node_type-no-gpu-request-fix
branch
from
85f9f63 to
864a669
Compare
Merged
nfx
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a situation when nodes with GPU were included into consideration even if there was no request to consider them - as result. For example, instead of expected
m5d.2xlargetheg4dn.2xlargewas selected.