-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gcp_managed_network_config optional #1365
Conversation
@@ -67,7 +67,7 @@ type GCPCommonNetworkConfig struct { | |||
|
|||
type GCPNetwork struct { | |||
NetworkID string `json:"network_id,omitempty"` | |||
GCPManagedNetworkConfig *GCPManagedNetworkConfig `json:"gcp_managed_network_config"` | |||
GCPManagedNetworkConfig *GCPManagedNetworkConfig `json:"gcp_managed_network_config,omitempty"` | |||
GCPCommonNetworkConfig *GCPCommonNetworkConfig `json:"gcp_common_network_config"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the other network? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcp_common_network_config
is still required AFAIK.
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
=========================================
Coverage ? 90.15%
=========================================
Files ? 124
Lines ? 10179
Branches ? 0
=========================================
Hits ? 9177
Misses ? 638
Partials ? 364
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In #1360 we added the
network_id
parameter toGCPNetwork
. If it is specified,gcp_managed_network_config
is optional and ignored by the backend.