Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip_validation for databricks_external_location #1330

Merged

Conversation

sridharitv
Copy link
Contributor

No description provided.

@nkvuong
Copy link
Contributor

nkvuong commented May 24, 2022

@sridharitv you can also add SkipValidation to the storage credential resource, as that is also validated during creation

@sridharitv
Copy link
Contributor Author

@sridharitv you can also add SkipValidation to the storage credential resource, as that is also validated during creation

@nkvuong Sorry I couldn't find API documentation for unity resources here & I don't see any validation errors or force save button in the UI as well. So I will refrain from modifying storage credential resource in this PR

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1330 (47c144c) into master (01656b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1330   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         118      118           
  Lines       10004    10005    +1     
=======================================
+ Hits         9064     9065    +1     
  Misses        559      559           
  Partials      381      381           
Impacted Files Coverage Δ
catalog/resource_external_location.go 100.00% <100.00%> (ø)

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nfx nfx merged commit 789f52c into databricks:master May 30, 2022
@nfx nfx changed the title Skip validation for unity external location Added skip_validation for databricks_external_location May 30, 2022
nfx added a commit that referenced this pull request May 30, 2022
## 0.5.9

* Added warning section for debug mode ([#1325](#1325)).
* Added ability to specify tags for `databricks_job` ([#1337](#1337)).
* Upgraded AWS provider for AWS guides. Added examples for account-level identities ([#1332](#1332)).
* Updated docs to use `application_id` as privilege for `databricks_service_principal` ([#1336](#1336)).
* Added `databricks_service_principal_role` resource ([#1340](#1340)).
* Fixed itegration testing image ([#1342](#1342), [#1343](#1343)).
* Added `skip_validation` for `databricks_external_location` ([#1330](#1330)).
* Added `alert_on_last_attempt` to `databricks_job` ([#1341](#1341)).
* Skip `make test` on doc-only changes ([#1339](#1339)).
* Improve common package test coverage ([#1344](#1344)).
* Re-create purged cluster for `databricks_mount` for AWS S3 ([#1345](#1345)).

Updated dependency versions:

* Bump google.golang.org/api from 0.79.0 to 0.80.0
* Bump github.com/Azure/go-autorest/autorest/adal from 0.9.19 to 0.9.20
@nfx nfx mentioned this pull request May 30, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* Add skip validation argument to external locations resource
* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants