Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating databricks_service_principal on Azure #1322

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix updating databricks_service_principal on Azure #1322

merged 1 commit into from
May 20, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented May 20, 2022

  • propagate application_id on SCIM PUT call for SPN on Azure
  • behavior should not affect AWS

Fix #1319

* propagate `application_id` on SCIM PUT call for SPN on Azure
* behavior should not affect AWS

Fix #1319
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1322 (05c6e27) into master (94a6474) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         118      118           
  Lines       10001    10004    +3     
=======================================
+ Hits         9061     9064    +3     
  Misses        559      559           
  Partials      381      381           
Impacted Files Coverage Δ
common/version.go 100.00% <ø> (ø)
scim/resource_service_principal.go 97.91% <100.00%> (+0.06%) ⬆️

@nfx nfx merged commit bc37c9b into master May 20, 2022
@nfx nfx deleted the issue/1319 branch May 20, 2022 11:56
@nfx nfx mentioned this pull request May 20, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* propagate `application_id` on SCIM PUT call for SPN on Azure
* behavior should not affect AWS

Fix databricks#1319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Removing service principal entitlement leads to Error: cannot update service
1 participant