Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make common.DataResource deterministic #1279

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Make common.DataResource deterministic #1279

merged 3 commits into from
Apr 28, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Apr 28, 2022

Fix #1264

@nfx nfx changed the title Fix common.DataResource semantics Make common.DataResource deterministic Apr 28, 2022
@nfx nfx requested a review from alexott April 28, 2022 19:43
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1279 (2d97eb0) into master (0b679a6) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   90.64%   90.59%   -0.06%     
==========================================
  Files         117      117              
  Lines        9944     9949       +5     
==========================================
- Hits         9014     9013       -1     
- Misses        552      556       +4     
- Partials      378      380       +2     
Impacted Files Coverage Δ
catalog/data_catalogs.go 100.00% <100.00%> (ø)
catalog/data_schemas.go 100.00% <100.00%> (ø)
catalog/data_tables.go 100.00% <100.00%> (ø)
common/resource.go 90.65% <100.00%> (+0.08%) ⬆️
jobs/data_jobs.go 73.33% <100.00%> (+1.90%) ⬆️
common/reflect_resource.go 91.85% <0.00%> (-1.53%) ⬇️

@nfx nfx merged commit 53337d0 into master Apr 28, 2022
@nfx nfx deleted the fix/1264 branch April 28, 2022 20:14
@nfx nfx mentioned this pull request Apr 29, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Multiple databricks_schemas/databricks_tables data sources resulting in wrong output
2 participants