-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent creation ofusers
and admins
groups
#1091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, maybe only requires make fmt
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
+ Coverage 90.93% 90.95% +0.01%
==========================================
Files 110 110
Lines 9469 9472 +3
==========================================
+ Hits 8611 8615 +4
+ Misses 509 508 -1
Partials 349 349
|
@alexott did run fmt, no changes |
@nfx hi! this has one main drawback/side effect: consider you want to deal with admins group memberships in terraform, and for this you imported the admins group within your modules. now, this piece of code won't work since it raises this error
|
i guess, I need now to refactor this to use the group data source |
Fix #1089