adding privatelink guide

[rportilla-databricks]

Adding guide for AWS private link setup for a customer managed VPC

[codecov]

Codecov Report

Merging #1084 (48becd4) into master (9830f3e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1084   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files         113      113           
  Lines        9655     9655           
=======================================
  Hits         8767     8767           
  Misses        524      524           
  Partials      364      364           

[nfx]

Please take a look at hub and spoke guide and docs/resources/mws_vpc_endpoint and make this guide more consistent with them

[nfx]

@rportilla-databricks any updates on this PR? :)

[rportilla-databricks]

I've made changes suggested but still need to convert the VPC code to use the VPC module - will have an update later today and ask for review. Thanks.

…

On Tue, Feb 8, 2022 at 8:35 AM Serge Smertin ***@***.***> wrote: @rportilla-databricks <https://github.com/rportilla-databricks> any updates on this PR? :) — Reply to this email directly, view it on GitHub <#1084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJCRAXDXO23ZTTZ6JUZBLJDU2EL2HANCNFSM5NN4RABA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

-- Ricardo Portilla Lead Solutions Architect, Ph.D Databricks Inc. ***@***.*** databricks.com

[nfx]

@rportilla-databricks any updates on this PR? :)

[rportilla-databricks]

I left a comment about the VPC. Please let me know your thoughts. Architecture image is loaded.

…

On Fri, Feb 11, 2022 at 9:56 AM Serge Smertin ***@***.***> wrote: @rportilla-databricks <https://github.com/rportilla-databricks> any updates on this PR? :) — Reply to this email directly, view it on GitHub <#1084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJCRAXB6MFJ3WHCJUIZVBH3U2UPSDANCNFSM5NN4RABA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

-- Ricardo Portilla Lead Solutions Architect, Ph.D Databricks Inc. ***@***.*** databricks.com

[nfx]

Overall comments:

1. cross-link to resource documentation, make it easy for consumers of this guide
2. when naming aws resources, include module prefix and vpc name - assume multiple instances of this module
3. always propagate tags from vpc to child resources - those things are important, as they contain ownership and departmental information
4. pay careful attention to the way how resources are named
5. run make fmt-docs

Please resolve every comment in this PR by clicking "resolve conversation" or continue commenting. That's how we track if all requests are addressed.

[nfx]

@rportilla-databricks can you also reference hashicorp/terraform-provider-aws#7148 in comments and VPCE resource docs? it serves as a good explanation why two-step apply is needed

[rportilla-databricks]

Yes, I will address all these and resolve comments.

…

On Sun, Feb 13, 2022 at 7:02 AM Serge Smertin ***@***.***> wrote: @rportilla-databricks <https://github.com/rportilla-databricks> can you also reference hashicorp/terraform-provider-aws#7148 <hashicorp/terraform-provider-aws#7148> in comments and VPCE resource docs? it serves as a good explanation why two-step apply is needed — Reply to this email directly, view it on GitHub <#1084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJCRAXAHRBOC7P3IGHJ533LU26MUFANCNFSM5NN4RABA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

-- Ricardo Portilla Lead Solutions Architect, Ph.D Databricks Inc. ***@***.*** databricks.com

[nfx]

I'll pick up changes from here