Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adb-vnet-injection to use azurerm v4 #148

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Update adb-vnet-injection to use azurerm v4 #148

merged 3 commits into from
Nov 14, 2024

Conversation

r3stl355
Copy link
Contributor

One of several updates to existing templates to make them compatible with azurerm v4, tracked in #144

Changes:

  1. Add subscription_id parameter: it is mandatory in azurerm v4
  2. Remove no_public_ip: it is true by default in azurerm v4
  3. Move the Teraform required module declaration to providers.tf for consistency with other modules
  4. Update README.md

@r3stl355
Update adb-vnet-injection to use azurerm 4
9a4f630 
Signed-off-by: Niko <ulmasov@hotmail.com>
@r3stl355 r3stl355 requested review from a team as code owners November 13, 2024 18:30
@r3stl355
change subsctipion_id parameter to prompt
e881c53 
Signed-off-by: Niko <ulmasov@hotmail.com>
@r3stl355
Copy link
Contributor Author

r3stl355 commented Nov 13, 2024 •
edited
Loading

Is this what you had in mind by #144 @alexott? If so then I'll proceed with other templates, if not then let me know what I need to adjust

alexott
alexott requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change required, otherwise - good

@alexott
Copy link
Collaborator

alexott commented Nov 13, 2024

@r3stl355 yes - that's what I meant by that - make sure that all modules work with azurerm 4.x

@r3stl355
remove no_public_ip parameter from readme
3d7d2fb 
Signed-off-by: Niko <ulmasov@hotmail.com>
@alexott alexott merged commit ac23fa7 into databricks:main Nov 14, 2024
@r3stl355 r3stl355 deleted the issue-144 branch November 14, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3stl355 @alexott