Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make creation of Azure resource group for Databricks workspace optional #115

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

alexott
Copy link
Collaborator

@alexott alexott commented Jan 19, 2024

Very often you need to deploy ADB workspace into existing resource group, but current adb-lakehouse module always creates a new resource group. This PR allows to specify existing resource group name, while keeping compatibility with the previous version by creating it by default (could be disabled with the new variable).

Very often you need to deploy ADB workspace into existing resource group, but current
`adb-lakehouse` module always creates a new resource group.  This PR allows to specify
existing resource group name, while keeping compatibility with the previous version by
creating it by default (could be disabled with the new variable).
@alexott alexott requested review from a team as code owners January 19, 2024 08:42
@alexott alexott enabled auto-merge (squash) January 19, 2024 09:20
@alexott alexott changed the title Make creation of resource group for Databricks workspace optional Make creation of Azure resource group for Databricks workspace optional Jan 23, 2024
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexott alexott merged commit fb433a0 into main Jan 23, 2024
@nfx nfx deleted the adb-lakehouse-bring-your-rg branch January 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants