Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binary dependency on org.apache.hadoop.fs.s3.S3FileSystem #94

Closed
wants to merge 1 commit into from

Conversation

JoshRosen
Copy link
Contributor

This removes an unintended binary dependency on the org.apache.hadoop.fs.s3.S3FileSystem class. Our use of this class introduced an implicit dependency on the hadoop-aws artifact, which is not present in EMR.

Fixes #92.

@JoshRosen JoshRosen added the bug label Sep 23, 2015
@JoshRosen JoshRosen added this to the 0.5.1 milestone Sep 23, 2015
@JoshRosen JoshRosen mentioned this pull request Sep 23, 2015
@jaley
Copy link
Contributor

jaley commented Sep 23, 2015

Thanks for taking care of that so fast!

Cc: @emlyn as he ran into his earlier today.
On 23 Sep 2015 19:48, "Josh Rosen" notifications@github.com wrote:

This removes an unintended binary dependency on the
org.apache.hadoop.fs.s3.S3FileSystem class. Our use of this class
introduced an implicit dependency on the hadoop-aws artifact, which is
not present in EMR.

Closes #92 #92.

You can view, comment on, or merge this pull request online at:

#94
Commit Summary

  • Avoid binary dependency on hadoop-aws classes.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#94.

@codecov-io
Copy link

Current coverage is 94.84%

Merging #94 into master will not affect coverage as of 2b4dc84

@@            master     #94   diff @@
======================================
  Files           11      11       
  Stmts          446     446       
  Branches       109     109       
  Methods          0       0       
======================================
  Hit            423     423       
  Partial          0       0       
  Missed          23      23       

Review entire Coverage Diff as of 2b4dc84

Powered by Codecov. Updated on successful CI builds.

@JoshRosen JoshRosen closed this in 059e735 Sep 23, 2015
@JoshRosen JoshRosen deleted the hadoop-aws-fix branch September 23, 2015 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants