Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ PECO - 1768 ] PySQL: adjust HTTP retry logic to align with Go and Nodejs drivers #467

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

jprakash-db
Copy link
Contributor

@jprakash-db jprakash-db commented Nov 11, 2024

Description

Adjusted the retry logic to be in align with the Go and Node JS drivers.

  • Implemented the exponential backoff algorithm for backoff time calculation
  • Updated the number of retries and and the default value ranges for the delay between retries

Tests

Added unit tests for testing different functionalities

@jprakash-db jprakash-db requested a review from gopalldb November 11, 2024 09:56
@jprakash-db jprakash-db self-assigned this Nov 11, 2024
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@jackyhu-db
Copy link
Collaborator

jackyhu-db commented Nov 15, 2024

Please include the unit test at least and integration test is even better

@jackyhu-db
Copy link
Collaborator

Please update PR description to be more specific (e.g. change the retry logic to use exponential backoff algorithm)

Copy link

@gopalldb gopalldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, add tests

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@jprakash-db jprakash-db merged commit 43fa964 into main Nov 20, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants