Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do not use cached entities in code generation (#403)" #409

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jun 1, 2023

This reverts commit 0af0ffc, otherwise, we miss the path parameters in the requests and break all SDKs
image

@nfx nfx requested review from andrewnester and pietern June 1, 2023 13:59
@pietern
Copy link
Contributor

pietern commented Jun 1, 2023

@andrewnester Put up the PR because without this change, fields incorrectly persist across multiple methods.

The proper fix should therefore be different. Is there some kind of mutation of these objects happening out of band?

@nfx
Copy link
Contributor Author

nfx commented Jun 1, 2023

well, that "fix" breaks the SDKs :) there's TODO still https://github.com/databricks/databricks-sdk-go/blob/main/openapi/code/service.go#L170-L173

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we need this patch in order to generate the CLI commands.

@nfx nfx merged commit 75faf14 into main Jun 1, 2023
@nfx nfx deleted the fix-path-params branch June 1, 2023 14:42
@andrewnester
Copy link
Contributor

@nfx could you point to where do we modify cached object which is required for correct generation of IntegrationId?

The fact that we have different behaviour for cached and non-cached object is a bit worrisome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants