Make to/from string methods private to the jsonschema package #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
approved these changes
Nov 3, 2023
Merged
andrewnester
added a commit
that referenced
this pull request
Nov 8, 2023
CLI: * Hide `--progress-format` global flag ([#965](#965)). * Make configure command visible + fix bundle command description ([#961](#961)). * Log process ID in each log entry ([#949](#949)). * Improve error message when `--json` flag is specified ([#933](#933)). Bundles: * Remove validation for default value against pattern ([#959](#959)). * Bundle path rewrites for dbt and SQL file tasks ([#962](#962)). * Initialize variable definitions that are defined without properties ([#966](#966)). Internal: * Remove mention of Lakehouse apps from the changelog ([#945](#945)). * Function to merge two instances of `config.Value` ([#938](#938)). * Make to/from string methods private to the jsonschema package ([#942](#942)). * Make Cobra runner compatible with testing interactive flows ([#957](#957)). * Added `env.UserHomeDir(ctx)` for parallel-friendly tests ([#955](#955)). Dependency updates: * Bump golang.org/x/mod from 0.13.0 to 0.14.0 ([#954](#954)). * Bump golang.org/x/text from 0.13.0 to 0.14.0 ([#953](#953)). * Bump golang.org/x/sync from 0.4.0 to 0.5.0 ([#951](#951)). * Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 ([#950](#950)). * Bump github.com/fatih/color from 1.15.0 to 1.16.0 ([#952](#952)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
CLI: * Hide `--progress-format` global flag ([#965](#965)). * Make configure command visible + fix bundle command description ([#961](#961)). * Log process ID in each log entry ([#949](#949)). * Improve error message when `--json` flag is specified ([#933](#933)). Bundles: * Remove validation for default value against pattern ([#959](#959)). * Bundle path rewrites for dbt and SQL file tasks ([#962](#962)). * Initialize variable definitions that are defined without properties ([#966](#966)). Internal: * Function to merge two instances of `config.Value` ([#938](#938)). * Make to/from string methods private to the jsonschema package ([#942](#942)). * Make Cobra runner compatible with testing interactive flows ([#957](#957)). * Added `env.UserHomeDir(ctx)` for parallel-friendly tests ([#955](#955)). Dependency updates: * Bump golang.org/x/mod from 0.13.0 to 0.14.0 ([#954](#954)). * Bump golang.org/x/text from 0.13.0 to 0.14.0 ([#953](#953)). * Bump golang.org/x/sync from 0.4.0 to 0.5.0 ([#951](#951)). * Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 ([#950](#950)). * Bump github.com/fatih/color from 1.15.0 to 1.16.0 ([#952](#952)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes a few methods private, exposing cleaner interfaces to get the string representations for enums and default values of a JSON Schema.
Tests
Manually, template initialization for the
default-pythontemplate still works as expected.