Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename init project-dir flag to output-dir #676

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

shreyas-goenka
Copy link
Contributor

Changes

This PR:

  1. Renames the project-dir flag to output-dir
  2. Makes the project dir flag optional. When unspecified we default to the current working directory.

Tests

Manually

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to check in with Paul about this change.

cmd/bundle/init.go Outdated Show resolved Hide resolved
Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
@shreyas-goenka shreyas-goenka added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 042fbaa Aug 17, 2023
@shreyas-goenka shreyas-goenka deleted the rename-project-dir-flag branch August 17, 2023 20:40
andrewnester added a commit that referenced this pull request Aug 24, 2023
CLI:
 * Added `databricks account o-auth-enrollment enable` command ([#687](#687)).

Bundles:
 * Do not try auto detect Python package if no Python wheel tasks defined ([#674](#674)).
 * Renamed `environments` to `targets` in bundle configuration ([#670](#670)).
 * Rename init project-dir flag to output-dir ([#676](#676)).
 * Added support for sync.include and sync.exclude sections ([#671](#671)).
 * Add template directory flag for bundle templates ([#675](#675)).
 * Never ignore root directory when enumerating files in a repository ([#683](#683)).
 * Improve 'mode' error message ([#681](#681)).
 * Added run_as section for bundle configuration ([#692](#692)).
@andrewnester andrewnester mentioned this pull request Aug 24, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 24, 2023
CLI:
* Added `databricks account o-auth-enrollment enable` command
([#687](#687)).

Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([#674](#674)).
* Renamed `environments` to `targets` in bundle configuration
([#670](#670)).
* Rename init project-dir flag to output-dir
([#676](#676)).
* Added support for sync.include and sync.exclude sections
([#671](#671)).
* Add template directory flag for bundle templates
([#675](#675)).
* Never ignore root directory when enumerating files in a repository
([#683](#683)).
* Improve 'mode' error message
([#681](#681)).
* Added run_as section for bundle configuration
([#692](#692)).
arpitjasa-db pushed a commit to arpitjasa-db/cli that referenced this pull request Sep 7, 2023
## Changes
This PR:
1. Renames the project-dir flag to output-dir
2. Makes the project dir flag optional. When unspecified we default to
the current working directory.

## Tests
Manually

---------

Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
arpitjasa-db pushed a commit to arpitjasa-db/cli that referenced this pull request Sep 7, 2023
CLI:
* Added `databricks account o-auth-enrollment enable` command
([databricks#687](databricks#687)).

Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([databricks#674](databricks#674)).
* Renamed `environments` to `targets` in bundle configuration
([databricks#670](databricks#670)).
* Rename init project-dir flag to output-dir
([databricks#676](databricks#676)).
* Added support for sync.include and sync.exclude sections
([databricks#671](databricks#671)).
* Add template directory flag for bundle templates
([databricks#675](databricks#675)).
* Never ignore root directory when enumerating files in a repository
([databricks#683](databricks#683)).
* Improve 'mode' error message
([databricks#681](databricks#681)).
* Added run_as section for bundle configuration
([databricks#692](databricks#692)).

Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants