Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BuildCLI function to testutil package #2211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Move BuildCLI function to testutil package #2211

wants to merge 4 commits into from
+58 −43

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jan 22, 2025 •
edited
Loading

Changes

This function is in general useful for black box testing. Thus this PR moves it to testutil.

I plan to use it in my upcoming PR for a process based telemetry logger: #2212

Tests

Existing tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@denik denik Awaiting requested review from denik denik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shreyas-goenka