Do not treat empty path as a local path #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
approved these changes
Aug 26, 2024
andrewnester
added a commit
that referenced
this pull request
Aug 28, 2024
CLI: * Disable prompt for storage-credentials get command ([#1723](#1723)). Bundles: * Do not treat empty path as a local path ([#1717](#1717)). * Correctly mark PyPI package name specs with multiple specifiers as remote libraries ([#1725](#1725)). * Improve error handling for /Volumes paths in mode: development ([#1716](#1716)). Internal: * Revert hc-install version to 0.7.0 ([#1711](#1711)). * Ignore CLI version check on development builds of the CLI ([#1714](#1714)). API Changes: * Added `databricks resource-quotas` command group. * Added `databricks policy-compliance-for-clusters` command group. * Added `databricks policy-compliance-for-jobs` command group. OpenAPI commit 3eae49b444cac5a0118a3503e5b7ecef7f96527a (2024-08-21) Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.44.0 to 0.45.0 ([#1719](#1719)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
CLI: * Disable prompt for storage-credentials get command ([#1723](#1723)). Bundles: * Do not treat empty path as a local path ([#1717](#1717)). * Correctly mark PyPI package name specs with multiple specifiers as remote libraries ([#1725](#1725)). * Improve error handling for /Volumes paths in mode: development ([#1716](#1716)). Internal: * Ignore CLI version check on development builds of the CLI ([#1714](#1714)). API Changes: * Added `databricks resource-quotas` command group. * Added `databricks policy-compliance-for-clusters` command group. * Added `databricks policy-compliance-for-jobs` command group. OpenAPI commit 3eae49b444cac5a0118a3503e5b7ecef7f96527a (2024-08-21) Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.44.0 to 0.45.0 ([#1719](#1719)). * Revert hc-install version to 0.7.0 ([#1711](#1711)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes issue introduced here #1699 where PyPi packages were treated as local library.
The reason is that
libraryPathreturns an empty string as a path for PyPi packages and thenIsLibraryLocaltreated empty string as local path.Both of these functions are fixed in this PR.
Tests
Added regression test