Move to a single prompt during bundle destroy #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
changed the title
pietern
reviewed
Jul 17, 2024
| // Core destructive mutators for destroy. These require informed user consent. | ||
| destroyCore := bundle.Seq( | ||
| terraform.Destroy(), | ||
| terraform.StatePush(), |
There was a problem hiding this comment.
(not blocking because it's the same as it was) Why do we push an empty state prior to deleting it?
There was a problem hiding this comment.
It seems related to keeping the state consistent before deleting files, to be robust against errors, before we delete root_path.
We used to release the lock before calling files.Delete(). I think it's okay to remove this, will send a followup PR.
pietern
reviewed
Jul 23, 2024
|
Thanks, LGTM. @andrewnester Could you review as well? |
andrewnester
approved these changes
Jul 24, 2024
andrewnester
added a commit
that referenced
this pull request
Jul 25, 2024
Bundles: * Add UUID function to bundle template functions ([#1612](#1612)). * Upgrade TF provider to 1.49.0 ([#1617](#1617)). * Upgrade TF provider to 1.49.1 ([#1626](#1626)). * Support multiple locations for diagnostics ([#1610](#1610)). * Split artifact cleanup into prepare step before build ([#1618](#1618)). * Move to a single prompt during bundle destroy ([#1583](#1583)). Internal: * Add tests for the Workspace API readahead cache ([#1605](#1605)). * Update Python dependencies before install when upgrading a labs project ([#1624](#1624)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
Bundles: * Add UUID function to bundle template functions ([#1612](#1612)). * Upgrade TF provider to 1.49.0 ([#1617](#1617)). * Upgrade TF provider to 1.49.1 ([#1626](#1626)). * Support multiple locations for diagnostics ([#1610](#1610)). * Split artifact cleanup into prepare step before build ([#1618](#1618)). * Move to a single prompt during bundle destroy ([#1583](#1583)). Internal: * Add tests for the Workspace API readahead cache ([#1605](#1605)). * Update Python dependencies before install when upgrading a labs project ([#1624](#1624)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## Changes Following up #1583 (comment). We can skip pushing because right after `root_path` is deleted, making this a no-op effectively. ## Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Right now we ask users for two confirmations when destroying a bundle. One to destroy the resources and one to delete the files. This PR consolidates the two prompts into one.
Tests
Manually
Destroying a bundle with no resources:
Destroying a bundle with no remote state:
When a user cancells a deployment:
When a user destroys resources: