Copy-editing for SQL templates #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
+ Coverage 52.25% 53.57% +1.31%
==========================================
Files 317 351 +34
Lines 18004 20271 +2267
==========================================
+ Hits 9408 10860 +1452
- Misses 7903 8612 +709
- Partials 693 799 +106 ☔ View full report in Codecov by Sentry. |
pietern
changed the title
pietern
approved these changes
Jun 5, 2024
pietern
added a commit
that referenced
this pull request
Jun 5, 2024
Bundles: This releases fixes an issue introduced in v0.221.0 where managing jobs with a single-node cluster would fail. * Fix SQL schema selection in default-sql template ([#1471](#1471)). * Copy-editing for SQL templates ([#1474](#1474)). * Upgrade TF provider to 1.47.0 ([#1476](#1476)). Internal: * Use latest version of goreleaser action ([#1477](#1477)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Bundles: This releases fixes an issue introduced in v0.221.0 where managing jobs with a single-node cluster would fail. * Fix SQL schema selection in default-sql template ([#1471](#1471)). * Copy-editing for SQL templates ([#1474](#1474)). * Upgrade TF provider to 1.47.0 ([#1476](#1476)). Internal: * Use latest version of goreleaser action ([#1477](#1477)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This applies changes suggested by @juliacrawf-db