Ensure that python dependencies are installed during upgrade #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim.Idle <jimi@idle.ws>
- Adds a stub to intercept the python -m pip install . command - Checks that the dependency install was in fact run in the upgrade process Signed-off-by: Jim.Idle <jimi@idle.ws>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 52.25% 52.88% +0.63%
==========================================
Files 317 338 +21
Lines 18004 19532 +1528
==========================================
+ Hits 9408 10330 +922
- Misses 7903 8436 +533
- Partials 693 766 +73 ☔ View full report in Codecov by Sentry. |
pietern
added a commit
that referenced
this pull request
Apr 25, 2024
This is a bugfix release. CLI: * Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)). Bundles: * Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)). * Allow variable references in non-string fields in the JSON schema ([#1398](#1398)). * Fix variable overrides in targets for non-string variables ([#1397](#1397)). * Fix bundle schema for variables ([#1396](#1396)). * Fix bundle documentation URL ([#1399](#1399)). Internal: * Removed autogenerated docs for the CLI commands ([#1392](#1392)). * Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)). * Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
This is a bugfix release. CLI: * Pass `DATABRICKS_CONFIG_FILE` for `auth profiles` ([#1394](#1394)). Bundles: * Show a better error message for using wheel tasks with older DBR versions ([#1373](#1373)). * Allow variable references in non-string fields in the JSON schema ([#1398](#1398)). * Fix variable overrides in targets for non-string variables ([#1397](#1397)). * Fix bundle schema for variables ([#1396](#1396)). * Fix bundle documentation URL ([#1399](#1399)). Internal: * Removed autogenerated docs for the CLI commands ([#1392](#1392)). * Remove `JSON.parse` call from homebrew-tap action ([#1393](#1393)). * Ensure that Python dependencies are installed during upgrade ([#1390](#1390)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The installer.Upgrade() processing did not install Python dependencies. This resulted in errors such as:
Any new dependencies are now installed during the upgrade process.
Resolves: databrickslabs/ucx#1276
Tests
The TestUpgraderWorksForReleases test now checks to see if the upgrade process resulted in the dependencies being installed.