Only set ComputeID value when --compute-id flag provided
#1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
- Coverage 52.43% 52.42% -0.01%
==========================================
Files 308 308
Lines 17587 17588 +1
==========================================
Hits 9221 9221
- Misses 7673 7674 +1
Partials 693 693 ☔ View full report in Codecov by Sentry. |
shreyas-goenka
approved these changes
Feb 22, 2024
andrewnester
added a commit
that referenced
this pull request
Feb 23, 2024
CLI: * Improved error message when no .databrickscfg ([#1223](#1223)). * Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)). Bundles: * Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)). * Add correct tag value for models in dev mode ([#1230](#1230)). * Upgrade Terraform provider to 1.37.0 ([#1235](#1235)). Internal: * Fix CLI nightlies on our UC workspaces ([#1225](#1225)). * Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
CLI: * Improved error message when no .databrickscfg ([#1223](#1223)). * Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)). Bundles: * Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)). * Add correct tag value for models in dev mode ([#1230](#1230)). * Upgrade Terraform provider to 1.37.0 ([#1235](#1235)). Internal: * Fix CLI nightlies on our UC workspaces ([#1225](#1225)). * Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue when
compute_idis defined in the bundle config, correctly replaced invalidatecommand but not used indeploycommandPreviously when
compute_idwas set in bundle.yml andbundle deploywas executed with no --compute-id flag, compute_id from bundle configuration file was reset to an empty string which is unexpected.Now, the value of
compute_idfrom bundle config only changed when the--compute-idflag is passedTests
Manually