Added warning when trying to deploy bundle with --fail-if-running and running resources
#1163
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
- Coverage 51.51% 51.42% -0.09%
==========================================
Files 292 293 +1
Lines 16322 16455 +133
==========================================
+ Hits 8408 8462 +54
- Misses 7308 7377 +69
- Partials 606 616 +10 ☔ View full report in Codecov by Sentry. |
andrewnester
changed the title
--fail-if-running and running resources
bundle/config/bundle.go
Outdated
|
|
||
| // FailIfRunning specifies whether to fail the deployment if there are | ||
| // running jobs or pipelines in the workspace. Defaults to false. | ||
| FailIfRunning bool `json:"fail_if_running,omitempty"` |
There was a problem hiding this comment.
The place of this field in the overall config seems odd:
bundle:
fail_if_running: trueIt's not clear what this pertains to. What would be a location to make its use more clear?
There was a problem hiding this comment.
@pietern we can have a Deployment similar to Lock one we have and put it under there?
There was a problem hiding this comment.
Sounds good -- we can consider moving the lock related fields there as well.
W.r.t. the name itself, it is ambiguous what is running: jobs or the deployment itself.
Alternative: fail_on_active_runs or fail_if_runs_active or something.
This is already handled when we call |
Bundles: * Allow specifying executable in artifact section and skip bash from WSL ([#1169](#1169)). * Added warning when trying to deploy bundle with `--fail-if-running` and running resources ([#1163](#1163)). * Group bundle run flags by job and pipeline types ([#1174](#1174)). * Make sure grouped flags are added to the command flag set ([#1180](#1180)). * Add short_name helper function to bundle init templates ([#1167](#1167)). Internal: * Fix dynamic representation of zero values in maps and slices ([#1154](#1154)). * Refactor library to artifact matching to not use pointers ([#1172](#1172)). * Harden `dyn.Value` equality check ([#1173](#1173)). * Ensure every variable reference is passed to lookup function ([#1176](#1176)). * Empty struct should yield empty map in `convert.FromTyped` ([#1177](#1177)). * Zero destination struct in `convert.ToTyped` ([#1178](#1178)). * Fix integration test with invalid configuration ([#1182](#1182)). * Use `acc.WorkspaceTest` helper from bundle integration tests ([#1181](#1181)).
Bundles: * Allow specifying executable in artifact section and skip bash from WSL ([#1169](#1169)). * Added warning when trying to deploy bundle with `--fail-if-running` and running resources ([#1163](#1163)). * Group bundle run flags by job and pipeline types ([#1174](#1174)). * Make sure grouped flags are added to the command flag set ([#1180](#1180)). * Add short_name helper function to bundle init templates ([#1167](#1167)). Internal: * Fix dynamic representation of zero values in maps and slices ([#1154](#1154)). * Refactor library to artifact matching to not use pointers ([#1172](#1172)). * Harden `dyn.Value` equality check ([#1173](#1173)). * Ensure every variable reference is passed to lookup function ([#1176](#1176)). * Empty struct should yield empty map in `convert.FromTyped` ([#1177](#1177)). * Zero destination struct in `convert.ToTyped` ([#1178](#1178)). * Fix integration test with invalid configuration ([#1182](#1182)). * Use `acc.WorkspaceTest` helper from bundle integration tests ([#1181](#1181)).
Changes
Deploying bundle when there are bundle resources running at the same time can be disruptive for jobs and pipelines in progress.
With this change during deployment phase (before uploading any resources) if there is
--fail-if-runningspecified DABs will check if there are any resources running and if so, will fail the deploymentTests
Manual + add tests