Release Windows packages to winget-pkgs #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
- Coverage 49.46% 49.44% -0.02%
==========================================
Files 281 281
Lines 10726 10726
==========================================
- Hits 5306 5304 -2
- Misses 4855 4857 +2
Partials 565 565 ☔ View full report in Codecov by Sentry. |
pietern
previously requested changes
Jan 25, 2024
.github/workflows/release.yml
Outdated
| runs-on: windows-latest | ||
| environment: release | ||
| steps: | ||
| - uses: vedantmgoyal2009/winget-releaser@v2 |
There was a problem hiding this comment.
Let's pin the commit sha instead of using a tag.
|
Let's wait to merge this before hearing back from legal. I think it is OK since 1) we're not incorporating code from that project, 2) we're not statically or dynamically linking to any artifacts from that project, and 3) we're not modifying any code from that project. |
|
This has been approved by legal, so we are good to merge. |
mgyucht
dismissed
pietern’s stale review
Addressed feedback and discussed offline.
Merged
shreyas-goenka
added a commit
that referenced
this pull request
Feb 1, 2024
This reverts commit 2f1b81c.
shreyas-goenka
added a commit
that referenced
this pull request
Feb 1, 2024
This reverts commit 3dbb205.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a release workflow which will automatically publish the CLI to winget-pkgs whenever a release is made. It uses https://github.com/vedantmgoyal2009/winget-releaser to release the windows binaries. @Exorcism0666 has been graciously making releases on our behalf, but we can do this automatically ourselves after this PR.
Tests