Skip to content

Commit

Permalink
Automated rollback of commit efa196c.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

This is breaking Bazel pre/postsubmit, particularly bazel_cc_code_coverage_test: https://buildkite.com/bazel/bazel-bazel/builds/20589#0183130a-f1df-4236-958b-99611f04160c

*** Original change description ***

Delete dead cc_binary implementation.

PiperOrigin-RevId: 472653638
Change-Id: Ie1d4edd5da5de0df6d5eac14aa163dc976d555e8
  • Loading branch information
Wyverald authored and copybara-github committed Sep 7, 2022
1 parent d2b4aba commit 16b16b0
Show file tree
Hide file tree
Showing 5 changed files with 1,566 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// Copyright 2014 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.devtools.build.lib.bazel.rules.cpp;

import com.google.devtools.build.lib.rules.cpp.CcBinary;

/**
* Factory class for the {@code cc_binary} rule.
*/
public class BazelCcBinary extends CcBinary {
public BazelCcBinary() {
super(BazelCppSemantics.CPP);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@
import com.google.devtools.build.lib.packages.RuleClass;
import com.google.devtools.build.lib.rules.cpp.CppConfiguration;

/**
* Rule definition for cc_binary rules.
*
* <p>This rule is implemented in Starlark. This class remains only for doc-gen purposes.
*/
/** Rule definition for cc_binary rules. */
public final class BazelCcBinaryRule implements RuleDefinition {

@Override
Expand Down Expand Up @@ -82,7 +78,7 @@ public Metadata getMetadata() {
return RuleDefinition.Metadata.builder()
.name("cc_binary")
.ancestors(CcBinaryBaseRule.class, BaseRuleClasses.BinaryBaseRule.class)
.factoryClass(BaseRuleClasses.EmptyRuleConfiguredTargetFactory.class)
.factoryClass(BazelCcBinary.class)
.build();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,7 @@
* Factory class for the {@code cc_test} rule.
*/
public class BazelCcTest extends CcTest {
public BazelCcTest() {}
public BazelCcTest() {
super(BazelCppSemantics.CPP);
}
}
Loading

0 comments on commit 16b16b0

Please sign in to comment.