Added new search #61
Merged
Added new search #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldcampbelljr
approved these changes
Oct 15, 2024
| """ | ||
|
|
||
| return QdrantBackend( | ||
| dim=384, |
There was a problem hiding this comment.
this just looks funny. why is it this specific number?
There was a problem hiding this comment.
Thats the dimensionality of the embeddings for sentence-transformers/all-MiniLM-L6-v2. So its fine iff the user will never be able to parametrize this particular variable.
Regardless, I agree it should be annotated with a comment or a constant that is-self-descriptive (i.e. EMBEDDING_DIMENSION to help explain whats going on)
Comment on lines
243
to
247
| search_backend = BiVectorBackend( | ||
| metadata_backend=self._qdrant_text_engine, bed_backend=self._qdrant_engine | ||
| ) | ||
| search_interface = BiVectorSearchInterface( | ||
| backend=search_backend, query2vec="sentence-transformers/all-MiniLM-L6-v2" |
There was a problem hiding this comment.
For the future, what is the difference between backend and interface? Is interface the correct term here?
Co-authored-by: Donald Campbell <125581724+donaldcampbelljr@users.noreply.github.com>
Co-authored-by: Donald Campbell <125581724+donaldcampbelljr@users.noreply.github.com>
Co-authored-by: Donald Campbell <125581724+donaldcampbelljr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes