Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): add Decimal128 and Decimal256 type #9856

Merged
merged 21 commits into from
Feb 4, 2023

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Feb 2, 2023

  • refactor
  • feat(expr): add Decimal128 and Decimal256 type

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Related to #2931

@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2023 at 8:03PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 2, 2023
@andylokandy andylokandy requested a review from sundy-li February 2, 2023 08:02
@BohuTANG
Copy link
Member

BohuTANG commented Feb 2, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

update

✅ Branch has been successfully updated

Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally Looks good to me.

@andylokandy
Copy link
Collaborator Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

update

✅ Branch has been successfully updated

@andylokandy
Copy link
Collaborator Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG merged commit 93ccb63 into databendlabs:main Feb 4, 2023
@sundy-li sundy-li mentioned this pull request Feb 10, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants