Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support like & not like #829

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Support like & not like #829

merged 2 commits into from
Jun 14, 2021

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Jun 14, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

support like and not like function

Changelog

  • New Feature

Related Issues

Fixes #784

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Jun 14, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Hello @b41sh, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@codecov-commenter
Copy link

Codecov Report

Merging #829 (b645c19) into master (3914655) will increase coverage by 0%.
The diff coverage is 81%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #829   +/-   ##
======================================
  Coverage      77%     77%           
======================================
  Files         323     325    +2     
  Lines       17750   17828   +78     
======================================
+ Hits        13813   13878   +65     
- Misses       3937    3950   +13     
Impacted Files Coverage Δ
common/datavalues/src/macros.rs 60% <ø> (ø)
common/datavalues/src/data_array_comparison.rs 56% <50%> (-1%) ⬇️
...ommon/datavalues/src/data_array_comparison_test.rs 85% <83%> (-1%) ⬇️
...ommon/functions/src/comparisons/comparison_test.rs 87% <87%> (ø)
common/datavalues/src/data_value_operator.rs 97% <100%> (+<1%) ⬆️
common/functions/src/comparisons/comparison.rs 84% <100%> (+<1%) ⬆️
...ommon/functions/src/comparisons/comparison_like.rs 100% <100%> (ø)
...n/functions/src/comparisons/comparison_not_like.rs 100% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3914655...b645c19. Read the comment docs.

Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit e97af99 into databendlabs:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[function] add like not like
4 participants