-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-enable (xor) bloom filter index #7870
fix: re-enable (xor) bloom filter index #7870
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Cool. Fuse 8 Disadvantages:
|
From the test,
|
183c789
to
08ea640
Compare
Test result: Gen data(unique):
main branch:
This branch:
XOR filter is ~2X faster and scans less data(only need to scan xor filter index):
With #7893 would be great for the point query. XOR index size(This is the worst case, because all my keys are unique): |
f1b7841
to
deeb3b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
as xor bloom has been merged in PR #7860, replace the vanilla bloom filter with it.
but will be removed if table data is dropped
so that, other types of indexes could be put in separated "dir"s
Fixes #issue