Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Grant and Revoke Share Object sql support #7009

Merged
merged 6 commits into from
Aug 8, 2022
Merged

feat: add Grant and Revoke Share Object sql support #7009

merged 6 commits into from
Aug 8, 2022

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Aug 5, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: add Grant and Revoke Share Object sql support

Fixes #issue #6998

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 8, 2022 at 4:55AM (UTC)

@lichuang lichuang requested review from Xuanwo and leiysky August 5, 2022 07:56
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 5, 2022
common/ast/src/parser/statement.rs Show resolved Hide resolved
common/ast/src/parser/statement.rs Outdated Show resolved Hide resolved
common/ast/tests/it/testdata/statement.txt Outdated Show resolved Hide resolved
common/ast/tests/it/testdata/statement.txt Outdated Show resolved Hide resolved
query/src/sql/planner/plans/share.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mergify mergify bot merged commit 43cbd00 into databendlabs:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants