Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(query): test fuse-table compatibility #6990

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Aug 4, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

ci(query): test fuse-table compatibility

Fuse table compatability test

This script tests whether a newer version databend-query can read fuse table data written
by a older version databend-query.

Usage

tests/fuse-compat/test-fuse-compat.sh <old_ver>

E.g. tests/fuse-compat/test-fuse-compat.sh 0.7.151 tests if the fuse-table written
by databend-query-0.7.151 can be read by current version databend-qeury.

Prerequisites

  • Current version of databend-query and databend-meta must reside in ./bins:

    • ./bins/current/databend-query
    • ./bins/current/databend-meta

    Since building a binary takes several minutes,
    this step is usually done by the calling process, e.g., the CI script.

Testing data

  • Suite tests/fuse-compat/compat-logictest/fuse_compat_write writes data into a fuse table via an old version query.
  • Suite tests/fuse-compat/compat-logictest/fuse_compat_read reads the data via current version query.

Fuse table maintainers update these two logictest scripts to let the write/read
operations cover fuse-table features.

TODO

  • Complete logictest script tests/fuse-compat/compat-logictest/{fuse_compat_write|fuse_compat_read} to cover fuse-table features.

Changelog

  • Build/Testing/CI

Related Issues

@vercel
Copy link

vercel bot commented Aug 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 5, 2022 at 2:28AM (UTC)

Fuse table compatability test

This script tests whether a newer version databend-query can read fuse table data written
by a older version databend-query.

Usage

```shell
tests/fuse-compat/test-fuse-compat.sh <old_ver>
```

E.g. `tests/fuse-compat/test-fuse-compat.sh 0.7.151` tests if the fuse-table written
by **databend-query-0.7.151** can be read by **current** version databend-qeury.

Prerequisites

- Current version of databend-query and databend-meta must reside in `./bins`:
    - `./bins/current/databend-query`
    - `./bins/current/databend-meta`

    Since building a binary takes several minutes,
    this step is usually done by the calling process, e.g., the CI script.

Testing data

- Suite `tests/fuse-compat/compat-logictest/fuse_compat_write` writes data into a fuse table via an old version query.
- Suite `tests/fuse-compat/compat-logictest/fuse_compat_read` reads the data via current version query.

Fuse table maintainers update these two `logictest` scripts to let the write/read
operations cover fuse-table features.

- Part of databendlabs#6557

TODO

- [ ] Complete logictest script `tests/fuse-compat/compat-logictest/{fuse_compat_write|fuse_compat_read}` to cover fuse-table features.
@drmingdrmer drmingdrmer changed the title M tests/query-compat/test-query-compat.sh ci(query): test fuse-table compatibility Aug 5, 2022
@drmingdrmer drmingdrmer marked this pull request as ready for review August 5, 2022 02:29
@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label Aug 5, 2022
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit 050c56f into databendlabs:main Aug 5, 2022
@drmingdrmer drmingdrmer deleted the 2-fuse-compat branch August 6, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants